Recursively create parent directories when creating config dir #3897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 6, 2025
Merged
Merged
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ma2bd
approved these changes
May 6, 2025
afck
approved these changes
May 7, 2025
Contributor
|
(Does this one line really need to be a separate PR in a stack? It gets rebased and CI triggered every time something below it in the stack changes… also, lots of GitHub notification noise.) |
ndr-ds
force-pushed
the
05-02-adjust_state_hash_computation_bucket
branch
from
63ff628 to
cd3ab06
Compare
ndr-ds
force-pushed
the
05-06-recursively_create_parent_directories_when_creating_config_dir
branch
from
d858999 to
1cfe578
Compare
ndr-ds
force-pushed
the
05-02-adjust_state_hash_computation_bucket
branch
from
cd3ab06 to
b7dd2db
Compare
ndr-ds
force-pushed
the
05-06-recursively_create_parent_directories_when_creating_config_dir
branch
from
1cfe578 to
2997a46
Compare
ndr-ds
force-pushed
the
05-02-adjust_state_hash_computation_bucket
branch
from
b7dd2db to
f6712ff
Compare
ndr-ds
force-pushed
the
05-06-recursively_create_parent_directories_when_creating_config_dir
branch
from
2997a46 to
296337d
Compare
This was referenced May 9, 2025
Contributor
Author
ndr-ds
changed the base branch from
05-02-adjust_state_hash_computation_bucket
to
graphite-base/3897
ndr-ds
force-pushed
the
05-06-recursively_create_parent_directories_when_creating_config_dir
branch
from
296337d to
77e7499
Compare
ndr-ds
deleted the
05-06-recursively_create_parent_directories_when_creating_config_dir
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When this path is executed from inside a docker container, which we usually run as root,
$HOMEwill point to/root, butdirs::config_dir()will actually return$HOME/.config, but the.configdirectory won't be created yet.Then when we call
fs_err::create_dir("/root/.config/linera"), it can fail because.configwon't exist yet.Proposal
Recursively create directories so that
.configis also created, and the command succeeds from within Docker containers as well.Test Plan
Deploys were failing with this, now they succeed.
Release Plan